Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add duration field & expose max_digits of FloatField #211

Merged
merged 6 commits into from
Oct 22, 2024
Merged

add duration field & expose max_digits of FloatField #211

merged 6 commits into from
Oct 22, 2024

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Oct 22, 2024

Changes:

  • improve tests
  • fix issue with loading when using reflected models
  • add duration fields
  • expose precision/max_digits of FloatField.

@devkral
Changes:
fb83d10 
- add duration field
@devkral
Changes:
cb970f1 
- move field tests to fields
- remove duplicate test file in run_sync
- add duration field test
@devkral
Changes:
c7e9366 
- update release notes
- expand tests for InspectDB
- expand tests for reflection
- test harder the correct reflection of fields
- expose max_digits for FloatField
@devkral
fix typings
e08d6e4
@devkral
expose precision
d27e3c8
@devkral devkral requested a review from tarsil October 22, 2024 10:19
tarsil
tarsil reviewed Oct 22, 2024
View reviewed changes
docs/fields.md Show resolved Hide resolved
tarsil
tarsil previously approved these changes Oct 22, 2024
View reviewed changes
@tarsil
Copy link
Collaborator

tarsil commented Oct 22, 2024

Nice cleaning there. The tests were great

@devkral
Copy link
Contributor Author

devkral commented Oct 22, 2024

We have still too few tests on reflection and multiple registries

@tarsil
Copy link
Collaborator

tarsil commented Oct 22, 2024

We have still too few tests on reflection and multiple registries

I agree. Unfortunately I didn't have the time by that time but I'm glad you increased at least a bit more.

@devkral devkral merged commit 0124e17 into main Oct 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil